Repository navigation
Fix Svelte image module reading the wrong resource field - #79
Merged
alexanderoster merged 1 commit intoOct 20, 2026
Merged
Conversation
ModuleImage.svelte read module.imageresourceuuid, but the core AMCModule_Image sets imageresource, so no <image> content rendered in the Svelte client. Read imageresource, and skip the null-UUID default so an image without a resource renders nothing instead of a broken image (same guard as the build/part/execution list thumbnails).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModuleImage.sveltereadmodule.imageresourceuuid, butAMCModule_Image.jssetsimageresource, so no<image>content rendered in the Svelte client.The null-UUID check matches the BuildList/PartList/ExecutionList thumbnails. Without it, the core default
00000000-…would request a broken image.Evidence
WidgetTest, Dashboard → "Machine View" (
<image resource="ui_logo">), Svelte client:/api/imagerequestmaxheight="80"Merge Danger
Door: two-way
Blast Radius: Svelte
<image>only